강의 일기장 작성, 조회 및 질문 목록 관리 API 추가 #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asp345
requested review from
davin111,
Hank-Choi and
SeonghaeJo
and removed request for
a team
Hank-Choi
reviewed
Jul 29, 2025
| @Bean | ||
| @DiaryDocs | ||
| fun diaryRouter() = | ||
| v1CoRouter { |
There was a problem hiding this comment.
오랫동안 방치되긴 했는데
v1CoRouter라는게 사실 구버전에서 버전 없이 요청하는 경우를 지원하기 위한 용도라
coRouter 써도 좋을듯
|
리뷰해준거 반영했는데 같은 이름의 activity가 여러 개 생성되게 하고 싶지 않아서 삭제는 없고 활성화/비활성화만 있고, id로 주고받는 부분은 안했어요 |
|
어라 근데 v1CoRouter를 써야 하는거 아니야? |
asp345
force-pushed
the
feature/lecture-diary
branch
from
d2b4d13 to
7ac3306
Compare
core/src/main/kotlin/diary/repository/DiarySubmissionRepository.kt
Outdated
Show resolved
Hide resolved
|
@eastshine2741 리뷰해준거 추가로 반영했어 내가 몇개 그냥 지나쳤었네.. |
eastshine2741
approved these changes
Aug 10, 2025
|
너무 늦어지는거 같아서 일단 머지할게요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아직 어떤 강의에 대해 알림을 보내는 부분은 구현 안했어요
activityType이나 question은 db에서 삭제되거나 내용이 수정되지 않고, activityType은 name을 unique하게 하고 활성/비활성화로 관리, question은 비활성화 시킨 다음 새로운 것을 추가하는 방식으로 관리하게 했습니다
서버와 통신할때 activityType은 이름으로, question은 id로 주고받도록 했는데 둘다 id가 낫다면 바꿔볼게요
/admin/diary 에 추가된것:
/diary 로 추가된것: