-
Notifications
You must be signed in to change notification settings - Fork 0
Fix: problem 테이블 중복 속성 제거 #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deveroskp
commented
Dec 29, 2025
- problem 테이블에 submission과 code_submission이 중복되어 발생한 경고에 대해서, code_submission을 제거하여 해결했습니다.
📝 WalkthroughWalkthrough세 개의 파일에서 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pyproject.tomlwacruit/src/database/migrations/versions/2025_12_31_2201-8f87f9c43aea_delete_code_submissions.py
🔇 Additional comments (1)
pyproject.toml (1)
33-33: sqladmin의 전이 의존성입니다.
python-multipart는 line 24의 sqladmin 0.16.0이 필요로 하는 의존성입니다. poetry.lock을 확인하면 sqladmin의 의존성에python-multipart = "*"가 명시되어 있으므로, 이 의존성 추가는 정당합니다. 또한^0.0.6버전 제약은 0.0.21까지의 패치 버전을 허용하므로 적절합니다.다만 sqladmin이 이미 이 의존성을 제공하는데 pyproject.toml에 명시적으로 나열한 이유를 설명해주세요.
...uit/src/database/migrations/versions/2025_12_31_2201-8f87f9c43aea_delete_code_submissions.py
Outdated
Show resolved
Hide resolved
...uit/src/database/migrations/versions/2025_12_31_2201-8f87f9c43aea_delete_code_submissions.py
Outdated
Show resolved
Hide resolved
348fd2b to
3b6116d
Compare
|
제가 착각했네요... 마이그레이션 파일 작성할 필요가 없군요 😢 |