Skip to content

[REVIEW] Fix/root page issue #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosscdh wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[REVIEW] Fix/root page issue #51

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31a6d2a
excldude root page for api renderer
Jan 2, 2020
823dadc
added BAKERY_RESULTS_PER_PAGE
Jan 2, 2020
1db0e21
notes from @zerolab
Jan 2, 2020
c72a05a
more efficient selector excluding root
Jan 2, 2020
e4860eb
Added basic test
Jan 2, 2020
28ae537
travis lint fix
Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/wagtailbakery/api_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
import os
import json
import logging
import os

from bakery.views import BuildableMixin
from django.conf import settings
from django.contrib.contenttypes.models import ContentType
from wagtail.api.v2.endpoints import PagesAPIEndpoint
from wagtail.api.v2.router import WagtailAPIRouter
from bakery.views import BuildableMixin

from wagtail.core.models import Page, Site
from wagtail.api.v2.router import WagtailAPIRouter
from wagtail.api.v2.endpoints import PagesAPIEndpoint

from django.contrib.contenttypes.models import ContentType

logger = logging.getLogger(__name__)

BAKERY_RESULTS_PER_PAGE = getattr(settings, 'BAKERY_RESULTS_PER_PAGE', 25)


class APIResponseError(Exception):
pass
Expand All @@ -24,7 +28,7 @@ def handle_api_error(response):


class APIListingView(BuildableMixin):
results_per_page = 20
results_per_page = BAKERY_RESULTS_PER_PAGE

@property
def build_method(self):
Expand Down Expand Up @@ -85,7 +89,7 @@ def build_object(self, obj):
self.build_file(path, page_content)

def build_queryset(self):
[self.build_object(o) for o in self.get_queryset().all()]
[self.build_object(o) for o in self.get_queryset().all() if o.is_root() is False]

def unbuild_object(self, obj):
"""
Expand Down