Add help text for referral rule (fixes #95)#148
Open
robmoorman wants to merge 1 commit intowagtail-nest:mainfrom
Open
Add help text for referral rule (fixes #95)#148robmoorman wants to merge 1 commit intowagtail-nest:mainfrom
robmoorman wants to merge 1 commit intowagtail-nest:mainfrom
Conversation
tomdyson
approved these changes
May 31, 2017
Collaborator
tomdyson
left a comment
tomdyson
left a comment
There was a problem hiding this comment.
This looks much better, if we don't mind the minor risk that a user enters google.com which could also match googlezcom.com.
kaedroho
reviewed
May 31, 2017
| """ | ||
| regex_string = models.TextField( | ||
| _("Regular expression to match the referrer")) | ||
| _("Referral"), help_text=_("Enter the domain name (like google.com) " |
There was a problem hiding this comment.
The . characters in domain names may be misinterpreted if the value of this field is still going to be interpreted as a regex.
kaedroho
reviewed
May 31, 2017
| @@ -0,0 +1,20 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This migration needs to be given a name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now multiple domain names we can a) use the regex or b) enter multiple rules