Skip to content

Try to fix django package importer #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stormheg wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Try to fix django package importer #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c7edd1
Set a user agent for the package import request
Stormheg Aug 13, 2025
14e058e
Add http status code check
Stormheg Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion wagtailio/packages/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,18 @@
from .models import Grid, Package


headers = {
"Accept": "application/json",
"User-Agent": "Wagtail.org Packages Importer",
}


Comment on lines +12 to +17
Copy link
Copy Markdown
Contributor

@p-r-a-v-i-n p-r-a-v-i-n Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no need of the headers.

Copy link
Copy Markdown
Member Author

@Stormheg Stormheg Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @p-r-a-v-i-n, the goal was to seem less suspicious to Cloudflare by not using the default User-Agent header set by requests.

This did not work, so I might change this to the header of a browser to see if that works instead.

def process(url="https://djangopackages.org/api/v4/grids/?q=wagtail"):
grid_data = requests.get(url).json() # noqa: S113
response = requests.get(url, headers=headers, timeout=10)
if not response.ok:
raise ValueError(f"Failed to fetch data from {url}: {response.status_code}")

grid_data = response.json()
Comment on lines +19 to +23
Copy link
Copy Markdown
Contributor

@p-r-a-v-i-n p-r-a-v-i-n Sep 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! but just opinon here:
what do you think of using try-except block here to raise error, bcs sometimes requests won't even allow to perform request.ok if respective server is down.

for item in grid_data.get("results", []):
title = item.get("title", "")
if "wagtail" in title.lower():
Expand Down