Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
Jan 11, 2026
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
Thanks. I'll have a closer look later.
Member
|
marking draft for now. |
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
commit: |
dai-shi
reviewed
Jan 13, 2026
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
Sorry for the delay. It looks like a good test. We should fix it. Thanks.
Comment on lines
+9
to
+10
| void push('/about'); | ||
| void push('/bar'); |
Member
There was a problem hiding this comment.
If the reproduction is such a simple way, I would probably consider putting the test case in an existing spec and fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1880