fix(router): empty router issue and added mapping#1979
Open
tylersayshi wants to merge 3 commits intomainfrom
Open
fix(router): empty router issue and added mapping#1979tylersayshi wants to merge 3 commits intomainfrom
tylersayshi wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
dai-shi
reviewed
Mar 6, 2026
Comment on lines
+678
to
+679
| // If this pathname is also a directory prefix for another static API | ||
| // route, emit as pathname/index to avoid file-system conflicts. |
Member
There was a problem hiding this comment.
I'm not sure about this. What use cases is this trying to cover?
Member
Author
There was a problem hiding this comment.
The one from #1978. It supports the empty staticPath as a / on /[...wildcard]
Member
There was a problem hiding this comment.
Hmm, but adding /index here seems wrong. Any other solution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1978