Skip to content

feat(router): support trailing slash#1980

Merged
dai-shi merged 10 commits intomainfrom
fix/trailing-slash
Mar 6, 2026
Merged

feat(router): support trailing slash#1980
dai-shi merged 10 commits intomainfrom
fix/trailing-slash

Conversation

@dai-shi
Copy link
Member

@dai-shi dai-shi commented Mar 6, 2026

close #1966

It refactors code too with new terminilogy:

  • pathname: URL's pathname, not normalized, can be both no-trailing-slash and trailing-slash
  • routePath: normalized with no-trailing-slash
  • path: Used for public API

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
waku Ready Ready Preview Mar 6, 2026 1:46pm

Request Review

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/waku@1980

commit: b295fcf

@dai-shi dai-shi marked this pull request as ready for review March 6, 2026 13:43
@dai-shi dai-shi merged commit c220518 into main Mar 6, 2026
28 checks passed
@dai-shi dai-shi deleted the fix/trailing-slash branch March 6, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to support trailing slash for file-based routing

1 participant