Skip to content

fix: add category field web_application to web application resource#96

Open
bsimonWallix wants to merge 2 commits intodevelopfrom
fix/issue90-web-application-category
Open

fix: add category field web_application to web application resource#96
bsimonWallix wants to merge 2 commits intodevelopfrom
fix/issue90-web-application-category

Conversation

@bsimonWallix
Copy link
Collaborator

Fixes #90

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the new web_application category field for web applications (API v3.12+) and deprecates the legacy jumphost category. The changes implement proper version-gating logic to prevent usage of incompatible categories based on API version.

  • Adds web_application category with validation and configuration logic for API v3.12+
  • Updates jumphost category to be deprecated for API v3.12+ with clear error messaging
  • Adds comprehensive test coverage for the new web_application category

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
templates/resources/application.md.tmpl Adds documentation and examples for web_application category, updates jumphost documentation with deprecation notices
bastion/resource_application_test.go Adds new test for web_application category, renames jumphost test with deprecation notes and version gating
bastion/resource_application.go Adds web_application to validation, implements configuration logic, updates jumphost version checks, fixes error message
Comments suppressed due to low confidence (2)

bastion/resource_application_test.go:160

  • The resource name 'testacc_Appli' in the jumphost test helper function should be 'testacc_Appli_jumphost' to match the updated resource references in the test assertions (lines 98, 101, 109, 111).
resource "wallix-bastion_application" "testacc_Appli" {

bastion/resource_application_test.go:228

  • The resource name 'testacc_Appli' in the jumphost update helper function should be 'testacc_Appli_jumphost' to match the updated resource references in the test assertions (lines 98, 101, 109, 111).
resource "wallix-bastion_application" "testacc_Appli" {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants