fix: add category field web_application to web application resource#96
Open
bsimonWallix wants to merge 2 commits intodevelopfrom
Open
fix: add category field web_application to web application resource#96bsimonWallix wants to merge 2 commits intodevelopfrom
bsimonWallix wants to merge 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new web_application category field for web applications (API v3.12+) and deprecates the legacy jumphost category. The changes implement proper version-gating logic to prevent usage of incompatible categories based on API version.
- Adds
web_applicationcategory with validation and configuration logic for API v3.12+ - Updates
jumphostcategory to be deprecated for API v3.12+ with clear error messaging - Adds comprehensive test coverage for the new web_application category
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/resources/application.md.tmpl | Adds documentation and examples for web_application category, updates jumphost documentation with deprecation notices |
| bastion/resource_application_test.go | Adds new test for web_application category, renames jumphost test with deprecation notes and version gating |
| bastion/resource_application.go | Adds web_application to validation, implements configuration logic, updates jumphost version checks, fixes error message |
Comments suppressed due to low confidence (2)
bastion/resource_application_test.go:160
- The resource name 'testacc_Appli' in the jumphost test helper function should be 'testacc_Appli_jumphost' to match the updated resource references in the test assertions (lines 98, 101, 109, 111).
resource "wallix-bastion_application" "testacc_Appli" {
bastion/resource_application_test.go:228
- The resource name 'testacc_Appli' in the jumphost update helper function should be 'testacc_Appli_jumphost' to match the updated resource references in the test assertions (lines 98, 101, 109, 111).
resource "wallix-bastion_application" "testacc_Appli" {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…plication-category
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90