Maybe Fix GitHub Pages

[wallstop]

Description

GitHub Pages header is broken (too sticky). I need to set up a local flow to test/preview before pushing. Removing the header is a stop-gap.

Related Issue

Fixes #

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

• I have added tests that prove my fix is effective or my feature works
• I have updated the documentation accordingly
• I have updated the CHANGELOG
• My changes do not introduce breaking changes, or breaking changes are documented

[Copilot]

Pull request overview

This PR addresses a GitHub Pages issue where the sticky header was malfunctioning. As a stop-gap solution, it completely hides the header and removes the scroll-margin-top CSS rules that were previously needed to prevent content from being hidden under the sticky header.

Changes:

• Hides the header element entirely using CSS
• Removes scroll-margin-top rules for headings across desktop, tablet, and mobile breakpoints
• Updates comment to clarify the header is being hidden rather than just having borders removed

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
assets/css/theme.css	Removes scroll-margin-top properties and related comments for headings across different media queries (tablet, mobile, and general section headings)
assets/css/style.scss	Changes header styling from removing borders to completely hiding it using display: none and other hiding properties

Comments suppressed due to low confidence (1)

assets/css/style.scss:69

• These CSS rules for header child elements (header ul, header li, header p, header h1, header a) are now ineffective since the header itself is hidden with display: none. Consider removing these rules as they serve no purpose when the header is not displayed.

header ul {
  border: none !important;
  background: transparent !important;
  box-shadow: none !important;
}

header li {
  border: none !important;
  border-right: none !important;
}

header p,
header h1,
header a {
  border: none !important;

[Copilot]

The scroll-margin-top properties have been removed for headings, but the sticky header CSS rules still remain in theme.css (lines 696-710) that make the header sticky. Additionally, comments referencing Issue #127 for sticky header support remain at lines 453 and 696. Since the header is now completely hidden, these sticky positioning rules and related comments should also be removed for consistency and to avoid confusion.

[wallstop]

@copilot open a new pull request to apply changes based on this feedback

[Copilot]

Using both display: none and visibility: hidden is redundant. The display: none property alone is sufficient to completely hide an element and remove it from the document flow. The additional visibility: hidden, height: 0, margin: 0, and padding: 0 properties have no effect when display: none is applied.

[wallstop]

@copilot open a new pull request to apply changes based on this feedback

[Copilot]

@wallstop I've opened a new pull request, #141, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@wallstop I've opened a new pull request, #142, to work on those changes. Once the pull request is ready, I'll request review from you.