-
Notifications
You must be signed in to change notification settings - Fork 119
server, agent: github app installation clone support #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benbroadaway
wants to merge
10
commits into
master
Choose a base branch
from
github-app-clone-basic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
505d38f
server, agent: github app installation clone support
benbroadaway 339fa48
refactor CacheKey to record
benbroadaway febbfdf
removed unused code, rename CacheKey
benbroadaway dfe9bc8
tidy
benbroadaway db0002e
remove unused provider for now
benbroadaway d86ae07
skip askpass for single-value secrets
benbroadaway a739a4b
add auth config 'id' attribute for future metrics
benbroadaway b788323
fix null default values
benbroadaway 7eb6f5b
tidy
benbroadaway 825cf73
Merge remote-tracking branch 'oss/master' into github-app-clone-basic
benbroadaway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
agent/src/main/java/com/walmartlabs/concord/agent/AgentAuthTokenProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package com.walmartlabs.concord.agent; | ||
|
|
||
| /*- | ||
| * ***** | ||
| * Concord | ||
| * ----- | ||
| * Copyright (C) 2017 - 2025 Walmart Inc. | ||
| * ----- | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * ===== | ||
| */ | ||
|
|
||
| import com.typesafe.config.Config; | ||
| import com.walmartlabs.concord.agent.remote.ApiClientFactory; | ||
| import com.walmartlabs.concord.common.AuthTokenProvider; | ||
| import com.walmartlabs.concord.common.ExternalAuthToken; | ||
| import com.walmartlabs.concord.github.appinstallation.GitHubAppInstallation; | ||
| import com.walmartlabs.concord.sdk.Secret; | ||
|
|
||
| import javax.annotation.Nullable; | ||
| import javax.inject.Inject; | ||
| import java.net.URI; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public class AgentAuthTokenProvider implements AuthTokenProvider { | ||
| private final List<AuthTokenProvider> authTokenProviders; | ||
|
|
||
| @Inject | ||
| public AgentAuthTokenProvider(GitHubAppInstallation githubProvider, | ||
| OauthTokenProvider oauthTokenProvider) { | ||
|
|
||
| this.authTokenProviders = List.of(githubProvider, oauthTokenProvider); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean supports(URI repo, @Nullable Secret secret) { | ||
| return authTokenProviders.stream() | ||
| .anyMatch(p -> p.supports(repo, secret)); | ||
| } | ||
|
|
||
| public Optional<ExternalAuthToken> getToken(URI repo, @Nullable Secret secret) { | ||
| for (var tokenProvider : authTokenProviders) { | ||
| if (tokenProvider.supports(repo, secret)) { | ||
| return tokenProvider.getToken(repo, secret); | ||
| } | ||
| } | ||
|
|
||
| return Optional.empty(); | ||
| } | ||
|
|
||
| public static class ConcordServerTokenProvider implements AuthTokenProvider { | ||
| private final ApiClientFactory apiClientFactory; | ||
| private final Config config; | ||
|
|
||
| @Inject | ||
| public ConcordServerTokenProvider(ApiClientFactory apiClientFactory, Config config) { | ||
| this.apiClientFactory = apiClientFactory; | ||
| this.config = config; | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| public boolean supports(URI repo, @Nullable Secret secret) { | ||
| // TODO implement | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ExternalAuthToken> getToken(URI repo, @Nullable Secret secret) { | ||
| // TODO implement | ||
| return Optional.empty(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
agent/src/main/java/com/walmartlabs/concord/agent/cfg/GitHubConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| package com.walmartlabs.concord.agent.cfg; | ||
|
|
||
| /*- | ||
| * ***** | ||
| * Concord | ||
| * ----- | ||
| * Copyright (C) 2017 - 2025 Walmart Inc. | ||
| * ----- | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * ===== | ||
| */ | ||
|
|
||
| import com.walmartlabs.concord.common.cfg.MappingAuthConfig; | ||
| import com.walmartlabs.concord.github.appinstallation.cfg.GitHubAppInstallationConfig; | ||
|
|
||
| import javax.inject.Inject; | ||
| import java.time.Duration; | ||
| import java.util.List; | ||
|
|
||
| public class GitHubConfiguration implements GitHubAppInstallationConfig { | ||
|
|
||
| private static final String CFG_APP_INSTALLATION = "github.appInstallation"; | ||
|
|
||
| private final GitHubAppInstallationConfig appInstallation; | ||
|
|
||
| @Inject | ||
| public GitHubConfiguration(com.typesafe.config.Config config) { | ||
| if (config.hasPath(CFG_APP_INSTALLATION)) { | ||
| var raw = config.getConfig(CFG_APP_INSTALLATION); | ||
| this.appInstallation = GitHubAppInstallationConfig.fromConfig(raw); | ||
| } else { | ||
| this.appInstallation = GitHubAppInstallationConfig.builder() | ||
| .authConfigs(List.of()) | ||
| .build(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public List<MappingAuthConfig> getAuthConfigs() { | ||
| return appInstallation.getAuthConfigs(); | ||
| } | ||
|
|
||
| @Override | ||
| public Duration getSystemAuthCacheDuration() { | ||
| return appInstallation.getSystemAuthCacheDuration(); | ||
| } | ||
|
|
||
| @Override | ||
| public long getSystemAuthCacheMaxWeight() { | ||
| return appInstallation.getSystemAuthCacheMaxWeight(); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.