Trigger API Endpoint call reduction #1251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project and do this sorting on the client side.
ibodrov
requested changes
Jan 18, 2026
console2/src/components/organisms/ProjectActivity/ProjectRepositories.tsx
Outdated
Show resolved
Hide resolved
console2/src/components/organisms/ProjectActivity/ProjectRepositories.tsx
Outdated
Show resolved
Hide resolved
| dispatch, | ||
| }); | ||
|
|
||
| const triggerInfo = useApi<TriggerEntry[]>(fetchTriggers, { |
Collaborator
There was a problem hiding this comment.
This triggerInfo object can contain an error, AFAIR? We should display it if that's the case.
Collaborator
Author
There was a problem hiding this comment.
on a per-trigger level, or the request as a whole? Is there a standard way of reporting errors or should I just add some UI element with a red background? I haven't crawled the frontend codebase as much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to reduce the amount of calls to the
/api/v2/triggerendpoint in the project repository view ; specifically in context of particularly large projects with many triggers it might be preferable to batch the data in one request rather than an arbitrarily large list of them that gets re-fetched any time there's a re-render (ie: when filtering the repository list). Also included is a debounce on the repository filter. Might be worth adding a configurable default debounce time (ie: in scenarios that debounce based on human input, the debounce time is configurable rather than hardcoded). Open to discussion on the value of such a configuration.