feat(cli): add duplicate dependency linter#1256
Open
hashwnath wants to merge 4 commits intowalmartlabs:masterfrom
Open
feat(cli): add duplicate dependency linter#1256hashwnath wants to merge 4 commits intowalmartlabs:masterfrom
hashwnath wants to merge 4 commits intowalmartlabs:masterfrom
Conversation
Adds a new linter to detect duplicate entries in configuration.dependencies. Reports duplicates as warnings (not errors) to avoid breaking existing flows while still providing helpful feedback to flow designers. Closes issue discussion in walmartlabs#19. Changes: - Add DuplicateDependencyLinter.java - Register linter in Lint.java - Add test case with duplicate dependencies
Added configuration.runtime: concord-v2 to lintV2DuplicateDeps/concord.yml to match the pattern used by the existing lintV2 test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following feedback on #1255, this PR implements a CLI linter warning for duplicate dependencies instead of a fail-fast validation error.
Addresses #19 by adding a non-breaking linting rule.
Changes
DuplicateDependencyLinter.java- detects duplicate entries inconfiguration.dependenciesLint.javalintV2DuplicateDepsTestwith corresponding test resourcesBehavior
concord lintTesting
lintV2DuplicateDepsTesttest caseReferences