Support leading vertical bar in union types (issue #465)#468
Merged
hlship merged 2 commits intowalmartlabs:masterfrom Oct 9, 2025
Merged
Support leading vertical bar in union types (issue #465)#468hlship merged 2 commits intowalmartlabs:masterfrom
hlship merged 2 commits intowalmartlabs:masterfrom
Conversation
|
|
Member
|
I'm finally getting a chance to look into the backlog of PRs for lacinia --- can you sign the CLA? |
Author
|
Hi! Yes, I’ve already signed the CLA. |
hlship
approved these changes
Oct 9, 2025
Member
hlship
left a comment
There was a problem hiding this comment.
I was surprised this worked w/o changes to the grammar, but you can see in the grammar that a leading | is expressly allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an optional leading vertical bar (|) in union type definitions in SDL, as specified in the official GraphQL specification.
Highlights:
The SDL parser now accepts union definitions with or without a leading vertical bar.
Added tests to ensure correct parsing of both formats.
Updated documentation (README) to reflect this new feature.
This change improves compatibility with other GraphQL tools and makes it easier to format long union type lists.
Reference: GraphQL Spec - Unions
Closes #465.