fix: drop inferred ingest pipeline for CSV and auto-detect delimited format#62
Merged
fix: drop inferred ingest pipeline for CSV and auto-detect delimited format#62
Conversation
…format CSV files are parsed client-side, so the ingest pipeline returned by _text_structure/find_structure is unnecessary and can cause conflicts. Also auto-switch sourceFormat to csv when the inferred structure is delimited. Made-with: Cursor
Merged
walterra
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_text_structure/find_structurewhen the detected format isdelimited(CSV). Client-side parsing already handles CSV splitting, so the server-side pipeline is redundant and can cause conflicts.detectedFormatfrom the inference result somain.jscan auto-switchsourceFormattocsvwhen the structure is detected as delimited.params.formatwhensourceFormatis notndjson, and fall through to the actualsourceFormatvalue instead of hardcodingndjsonas the default.Test plan
infer_mappings.test.jsto assert no ingest pipeline is created for CSVyarn testlocally (requires Docker)