fix(weave): WEAVE_DEBUG_HTTP exception on server_info check#6137
Open
jamie-rasmussen wants to merge 1 commit intomasterfrom
Open
fix(weave): WEAVE_DEBUG_HTTP exception on server_info check#6137jamie-rasmussen wants to merge 1 commit intomasterfrom
jamie-rasmussen wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=7c2157711b03ae46946e46c3a5410e1c5e6bf431 |
9dc419c to
20ae9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was doing a
WEAVE_DEBUG_HTTP=1 python3 test.pywhere test.py just imported weave and init'ed a project, and it was showing retries before throwing a RuntimeError:This might have been broken by the switch to httpx in #5502 ?
Claude's analysis and fix is in this PR.