Open
Conversation
added 2 commits
November 17, 2017 17:19
|
@Alex601t have you tested this? I would look at the code again and remove force unwraps, rename the method image(from:at) to something different, and would check the prepareCache function since the calling to that function is not correct. |
Yuya-Tominaga-VIT
pushed a commit
to GroupVantageApps/AImage
that referenced
this pull request
Apr 9, 2020
Yuya-Tominaga-VIT
pushed a commit
to GroupVantageApps/AImage
that referenced
this pull request
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wangjwchn hey! I'm back 😎. So, I have a good news for us:
Testing on (iPhone 6s, 11.1, Xcode 9.1 (9B55))
Old implementation: https://puu.sh/ynWBq/affb71ab10.png
After small changes: https://puu.sh/ynWBT/8ecccbad27.png
Resource: https://wangjwchn.github.io/image/view.gif
@wangjwchn Could you test as you wish and review code ?
Refactor: