Add unknownProperty and size to IgnoredGlobalFields list#10108
Open
mkszepp wants to merge 2 commits intowarp-drive-data:mainfrom
Open
Add unknownProperty and size to IgnoredGlobalFields list#10108mkszepp wants to merge 2 commits intowarp-drive-data:mainfrom
unknownProperty and size to IgnoredGlobalFields list#10108mkszepp wants to merge 2 commits intowarp-drive-data:mainfrom
Conversation
runspired
reviewed
Aug 6, 2025
| import { Checkout, Commit, Context, Destroy } from './symbols.ts'; | ||
|
|
||
| const IgnoredGlobalFields = new Set<string>(['length', 'nodeType', 'then', 'setInterval', 'document', STRUCTURED]); | ||
| const IgnoredGlobalFields = new Set<string>(['length', 'nodeType', 'then', 'setInterval', 'document', 'unknownProperty', 'size', STRUCTURED]); |
Contributor
There was a problem hiding this comment.
size is a pretty odd one to need, what's the story there? 'length' is here because its what ember uses for isEmpty and JS uses to determine if something is ArrayLike, I'm not familiar with anything using size
Contributor
Author
There was a problem hiding this comment.
after adding unknownProperty to ignore list, i was running into size error... for this reason i have also added... after both, app works fine
Contributor
Author
There was a problem hiding this comment.
https://api.emberjs.com/ember/release/functions/@ember%2Futils/isEmpty looks like its implemented this one isEmpty({ size: 0}); // true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #10096
While using
isEmptyand@ember/utilswith schema-record i was running into errorError: No field named unknownProperty on user.To resolve this issue we need to add
unknownPropertyandsizetoIgnoredGlobalFields