Add extensions docs and start model fragments examples#10455
Open
RobbieTheWagner wants to merge 2 commits intomainfrom
Open
Add extensions docs and start model fragments examples#10455RobbieTheWagner wants to merge 2 commits intomainfrom
RobbieTheWagner wants to merge 2 commits intomainfrom
Conversation
runspired
added
🎯 canary
15 tasks
runspired
reviewed
Jan 28, 2026
| }; | ||
| const isBuiltIn = builtInExtensions[extension.kind].includes(extension.name); | ||
|
|
||
| warn( |
Contributor
There was a problem hiding this comment.
this would catch us registering our own, I suspect the assertion below is enough to catch duplicate
runspired
reviewed
Jan 28, 2026
| * like custom getters, computeds, and methods | ||
| */ | ||
| objectExtensions?: string[]; | ||
| objectExtensions?: (BuiltInObjectExtension | string)[]; |
Contributor
There was a problem hiding this comment.
we don't automatically make these available ... but hinting at them could be useful. I wonder if its enough to link them in the comment?
Contributor
Author
There was a problem hiding this comment.
I was just trying to expose the possible ones people could use. We could make it generic I suppose and try to dynamically populate them somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR updates API docs, preview them by:
pnpm installin the root (if needed)pnpm previewin the root