Feature/json schema for themes #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 21, 2023 17:31
Author
|
What about to review this PR? ;) |
3 tasks
Author
|
JSON schemas for Warp are available here now. PR is closed as I didn't get any response from project maintainers in a reasonable time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Discord username (optional)
If you're in our Discord server, we'd like to give you the Contributor Discord Role, please include
your username. Note: It must be labelled like so: username#4747 (make sure to include the #XXXX).
Emily Grace Seville#9556Name of theme
null
How Has This Been Tested?
Have you run the python script?
python3 ./scripts/gen_theme_previews.py <folder-name-eg-standard>Notes
We cannot accept pull request that include custom background images because:
If your theme has an intended custom background image, include a comment in the yaml with a link to
where people should download it.
Screenshots
Notes
Intellisence is enabled now for all themes so anybody can take advantage of it while creating new themes.
YAML Red Hat extension is required to be able to use hints and validate themes on the fly.