fix(sql): add IAM token refresh support for sql_select processor #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using IAM authentication for RDS, the token expires after ~15 minutes. The sql_select processor now detects connection failures (driver.ErrBadConn) and automatically reconnects with a fresh IAM token, then retries the query. Changes: - Store driver, dsn, and connSettings on struct for reconnection - Add reconnect() method that closes old connection and establishes new one - Detect driver.ErrBadConn in ProcessBatch and trigger reconnection - Retry failed query after successful reconnection Related to: warpstreamlabs#469
Author
|
THIS IS NOT TO BE MERGED YET. the fix was "vibed" and havent been tested yet. it seems like the above fix on #469 only apply to partial sql methods. not sure if this is the right way to add the reconnect mechanism. so treat this contribute as a proposal for a fix. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IAM authentication for RDS, the token expires after ~15 minutes. The sql_select processor now detects connection failures (driver.ErrBadConn) and automatically reconnects with a fresh IAM token, then retries the query.
Changes:
Related to: #469