Feat: Add no-member-access rule #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changqing-JING
requested changes
Jun 6, 2025
Changqing-JING
requested changes
Jun 19, 2025
Changqing-JING
requested changes
Jun 30, 2025
Changqing-JING
requested changes
Jul 1, 2025
Changqing-JING
previously approved these changes
Jul 1, 2025
Changqing-JING
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new ESLint rule for optimizing repeated member access patterns in AssemblyScript code. The rule aims to improve performance, readability, and maintainability by suggesting the extraction of frequently accessed member chains into variables. Additionally, the pull request includes updates to documentation, plugin configuration, and test cases to support and validate the new rule.
New ESLint Rule:
no-repeated-member-accessImplementation of Rule:
no-repeated-member-accessrule inplugins/rules/memberAccess.ts. This rule identifies repeated member access patterns and suggests extracting them into variables for better performance and readability. It avoids warning for computed properties, array indices, or properties modified within the scope.plugins/perfPlugin.ts.Documentation:
no-repeated-member-accessrule indocs/rules/no-repeated-member-access.md. This includes rule details, options, examples (correct and incorrect usage), and related rules.Testing Enhancements
no-repeated-member-accessrule intests/rules/noRepeatedMemberAccess.test.ts. These cover valid scenarios, invalid scenarios, and edge cases to ensure the rule behaves as expected.tests/perfPlugin.test.tsto include the new rule's tests.