Skip to content

Fix script for publish #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix script for publish #8

wants to merge 2 commits into from

Conversation

xpirad
Copy link
Contributor

@xpirad xpirad commented Jul 15, 2025

Fix logic for publish.

Configuration updates:

  • eslint.config.publish.mjs: Renamed from sample_config/sample_eslint.config.mjs , this is now part of the package distribution and made easier to access.

Packaging updates:

  • package.json: Updated the files field to include eslint.config.publish.mjs and exclude unnecessary dist/tests from the package distribution.

@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 06:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the package distribution settings and adjusts the ESLint config path for publishing.

  • Update package.json to include the ESLint config file and attempt to exclude test files from the published package
  • Adjust import path in eslint.config.publish.mjs to reflect the config’s new location

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Added "!dist/tests" (negation) and "eslint.config.publish.mjs" to the files array
eslint.config.publish.mjs Changed plugin import from ../index.js to ./index.js
Comments suppressed due to low confidence (2)

eslint.config.publish.mjs:5

  • [nitpick] Update the comment to note that index.js should now reside alongside this config file, reflecting its new root-level location.
import localPlugin from "./index.js"; // Assumes index.js is the entry point

package.json:30

  • npm’s files field does not support negation patterns (e.g., "!dist/tests"). To exclude dist/tests from the published package, remove this entry and instead add dist/tests to .npmignore.
    "!dist/tests",

HerrCai0907
HerrCai0907 previously approved these changes Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants