Skip to content

Added flags option to the precompile step #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

Added flags option to the precompile step #27

merged 3 commits into from
May 8, 2025

Conversation

nguterresn
Copy link
Contributor

The current implementation doesn't import the flags into the precompile step. This is a bit annoying when the main compilation requires the usage of --path to link different packages.

Let me know if this looks OK.

@nguterresn nguterresn requested a review from a team as a code owner May 7, 2025 09:06
HerrCai0907
HerrCai0907 previously approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HerrCai0907 HerrCai0907 enabled auto-merge (squash) May 8, 2025 06:05
@HerrCai0907 HerrCai0907 merged commit b53f4ff into wasm-ecosystem:main May 8, 2025
1 check passed
@nguterresn
Copy link
Contributor Author

Thanks!
Could you create a new release so we can consume the new changes through npm? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerrCai0907 HerrCai0907 HerrCai0907 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguterresn @HerrCai0907