Skip to content

Refactor: improve performance and reduce memory cost during precompile and compile stage #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Refactor: improve performance and reduce memory cost during precompile and compile stage #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8563bff
improve performance and reduce memory cost during precompile and comp…
XMadrid Jun 4, 2025
8efd196
return -1 while test crash due to node heap out of memory
XMadrid Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bin/as-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,10 @@ const testapp = spawn("node", argv, { stdio: "inherit" });
testapp.on("close", function (code) {
exit(code);
});

testapp.on("exit", (_code, signal) => {
if (signal === "SIGABRT") {
// node heap out of memory
exit(-1);
}
});
9 changes: 5 additions & 4 deletions src/core/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { join, relative } from "node:path";
import { findRoot } from "../utils/pathResolver.js";

export async function compile(testCodePaths: string[], outputFolder: string, compileFlags: string): Promise<string[]> {
const pms: Promise<void>[] = [];
const wasm: string[] = [];
const root = findRoot(testCodePaths);
const compile = async (testCodePath: string) => {
Expand Down Expand Up @@ -33,10 +32,12 @@ export async function compile(testCodePaths: string[], outputFolder: string, com
throw error;
}
};
for (const testCodePath of testCodePaths) {
pms.push(compile(testCodePath));

// Here, for-await is more efficient and less memory cost than Promise.all()
for (const codePath of testCodePaths) {
await compile(codePath);
}
await Promise.all(pms);

return wasm;
}

Expand Down
11 changes: 7 additions & 4 deletions src/core/precompile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@ export async function precompile(
const testCodePaths = testcases ?? getRelatedFiles(includes, excludes, (path: string) => path.endsWith(".test.ts"));

const sourceCodePaths = getRelatedFiles(includes, excludes, (path: string) => !path.endsWith(".test.ts"));
const sourceCodeTransforms: Promise<void>[] = [];
for (const sourceCodePath of sourceCodePaths.values()) {
sourceCodeTransforms.push(transform(sourceCodePath, transformFunction, flags));

// The batchSize = 2 is empirical data after benchmarking
const batchSize = 2;
for (let i = 0; i < sourceCodePaths.length; i += batchSize) {
await Promise.all(
sourceCodePaths.slice(i, i + batchSize).map((sourcePath) => transform(sourcePath, transformFunction, flags))
);
}
await Promise.all(sourceCodeTransforms);

return {
testCodePaths,
Expand Down