Skip to content

add pnpm as a package manager for isntalling the wasm-pack #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
woss wants to merge 2 commits into from
Closed

add pnpm as a package manager for isntalling the wasm-pack #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
275c9e5
add pnpm as a package manager for isntalling the wasm-pack
woss Sep 24, 2021
e34a6af
add pnpm as an installation method
woss Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ Or with Yarn:
yarn add --dev @wasm-tool/wasm-pack-plugin
```

Or with Pnpm:
```sh
pnpm add -D @wasm-tool/wasm-pack-plugin
```

### `wasm-pack`

We expect `wasm-pack` to be in your `$PATH`. See [installation here](https://rustwasm.github.io/wasm-pack/installer).
Expand Down Expand Up @@ -74,7 +79,9 @@ module.exports = {

// Controls plugin output verbosity, either 'info' or 'error'.
// Defaults to 'info'.
// pluginLogLevel: 'info'
// pluginLogLevel: 'info',
// // Controls which package manager will be used to install the wasm-pack.
// packageManager: 'npm', //Options are [npm|yarn|pnpm]
}),

]
Expand Down
1 change: 1 addition & 0 deletions plugin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface WasmPackPluginOptions {
watchDirectories?: string[];
/** Controls plugin output verbosity. Defaults to 'info'. */
pluginLogLevel?: 'info' | 'error';
packageManager: 'npm' | 'yarn' | 'pnpm'
}

export default class WasmPackPlugin {
Expand Down
7 changes: 5 additions & 2 deletions plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class WasmPackPlugin {
this.watchDirectories = (options.watchDirectories || [])
.concat(path.resolve(this.crateDirectory, 'src'));
this.watchFiles = [path.resolve(this.crateDirectory, 'Cargo.toml')];
this.packageManager = options.packageManager ? options.packageManager : 'npm';

if (options.pluginLogLevel && options.pluginLogLevel !== 'info') {
// The default value for pluginLogLevel is 'info'. If specified and it's
Expand Down Expand Up @@ -135,10 +136,12 @@ class WasmPackPlugin {

info('ℹ️ Installing wasm-pack \n');

if (commandExistsSync("npm")) {
if (this.packageManager === 'npm' && commandExistsSync("npm")) {
return runProcess("npm", ["install", "-g", "wasm-pack"], {});
} else if (commandExistsSync("yarn")) {
} else if (this.packageManager === 'yarn' && commandExistsSync("yarn")) {
return runProcess("yarn", ["global", "add", "wasm-pack"], {});
} else if (this.packageManager === 'pnpm' && commandExistsSync("pnpm")) {
return runProcess("pnpm", ["add", "--global", "wasm-pack"], {});
} else {
error(
"⚠️ could not install wasm-pack, you must have yarn or npm installed"
Expand Down