chore: clean up example component repos#359
Open
ericgregory wants to merge 2 commits intowasmCloud:mainfrom
Open
chore: clean up example component repos#359ericgregory wants to merge 2 commits intowasmCloud:mainfrom
ericgregory wants to merge 2 commits intowasmCloud:mainfrom
Conversation
Signed-off-by: Eric Gregory <eric@cosmonic.com>
Signed-off-by: Eric Gregory <eric@cosmonic.com>
thomastaylor312
approved these changes
Aug 14, 2025
Contributor
|
Sorry @ericgregory this slipped through the cracks. If you can get the tests passing, this should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to wasmCloud/wasmcloud.com#947, this PR updates compatibility warnings on component examples to reflect the current state of wasm-tools compatibility for each:
http-clientis fine with latest wasm-tools ✅http-password-checkeris fine with latest wasm-tools ✅http-serveris fine with latest wasm-tools ✅wasitel-httpis fine with latest wasm-tools ✅http-keyvalue-crudrequires wasm-tools v1.225.0 ❌invokecomponent requires wasm-tools v1.225.0 ❌sqldb-postgresrequires wasm-tools v1.225.0 ❌This PR removes the admonitions from the examples that work with the latest wasm-tools, but adds a note in the troubleshooting section at the bottom. It also adds a minimal readme for wasitel-http in order to include the troubleshooting note.
While we're updating, this PR also applies the best practice of excluding generated bindings from Git repos consistently across the examples, removing the ones that were present and updating gitignores accordingly.