Unify our naming around the generated app (code)

[FranjoMindek]

We had an old TODO:

generatedCodeDirInDotWaspDir :: Path' (Rel DotWaspDir) (Dir G.Common.ProjectRootDir)
-- TODO: We sometimes call this directory "ProjectRootDir" and sometimes
-- "GeneratedCodeDir". We should unify the naming (the latter is the beter
-- name).
generatedCodeDirInDotWaspDir = [reldir|out|]

The name ProjectRootDir is really confusing because it is very close to WaspProjectDir and it's easy to confuse the two.

The ProjectRootDir is of course the .wasp/out/ dir.
The WaspProjectDir is the user's project root dir.

Most likely the reason why the TODO suggests using the GeneratedCodeDir dir instead.

I wanted to resolve this issue since these names often confused me, and Claude can do it easily. But renaming to GeneratedCodeDir gave me another problem.

Now we had all: GeneratedCodeDir, AppComponentRootDir and GeneratedSrcDir in Wasp/Generator/Common.hs. The problem is that all these names are related and concepts with structure, but that is not clear in their names.

AppComponentRootDir is app component in GeneratedCodeDir, e.g. .wasp/out/server/.
GeneratedSrcDir is src/ dir in any app component, e.g. .wasp/out/server/src/.

So I refactored further:
ProjectRootDir -> GeneratedAppDir
AppComponentRootDir -> GeneratedAppComponentDir
GeneratedSrcDir -> GeneratedAppComponentSrcDir

In other words, I'm throwing away the whole "generated code" term and I'm suggesting using the "generated app" term instead. Other than that, I make sure that names related to this concept include it as a prefix.

The most important file to look at is: waspc/src/Wasp/Generator/Common.hs

[FranjoMindek]

Just moved it below, so all connected data is next to each other.

[pkg-pr-new]

Open in StackBlitz

@wasp.sh/wasp-cli

npx https://pkg.pr.new/@wasp.sh/wasp-cli@3949

@wasp.sh/wasp-cli-darwin-arm64-unknown

npx https://pkg.pr.new/@wasp.sh/wasp-cli-darwin-arm64-unknown@3949

@wasp.sh/wasp-cli-darwin-x64-unknown

npx https://pkg.pr.new/@wasp.sh/wasp-cli-darwin-x64-unknown@3949

@wasp.sh/wasp-cli-linux-x64-glibc

npx https://pkg.pr.new/@wasp.sh/wasp-cli-linux-x64-glibc@3949

@wasp.sh/wasp-cli-linux-x64-musl

npx https://pkg.pr.new/@wasp.sh/wasp-cli-linux-x64-musl@3949

commit: 9e3d495

[infomiho]

Much better, nice!

Left one comment

[infomiho]

While we are here, let's maybe drop the ejecting bit? We don't really talk about that concept anywhere as a supported thing. Of course you can take the code and go with it, but you can't really eject from Wasp or Wasp SDK anymore.

[infomiho]

Forgot to approve