Skip to content

Dodanie modala potwierdzenia dla wszystkich resouców + podbicie wersj…#1017

Open
MichalKarol wants to merge 1 commit intowatchdogpolska:devfrom
MichalKarol:task/950-modal-potwierdzenia
Open

Dodanie modala potwierdzenia dla wszystkich resouców + podbicie wersj…#1017
MichalKarol wants to merge 1 commit intowatchdogpolska:devfrom
MichalKarol:task/950-modal-potwierdzenia

Conversation

@MichalKarol
Copy link
Collaborator

@MichalKarol MichalKarol commented Jul 26, 2021

…i antd

@MichalKarol MichalKarol requested review from ad-m and fervero July 26, 2021 23:48
ad-m
ad-m approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@ad-m ad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Czytelna i przejrzysta zmiana 🥇

@ad-m
Copy link
Member

ad-m commented Aug 5, 2021

@fervero czy masz w zakresie tej zmiany własne uwagi?

@fervero
Copy link
Collaborator

fervero commented Aug 6, 2021

@ad-m w sumie jedną: w paru miejscach mamy konstrukcję doSomething().then(callback).catch(ten sam callback). Powinno dać się zastąpić jednym .finally(callback).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ad-m ad-m ad-m approved these changes

@fervero fervero Awaiting requested review from fervero

Assignees

No one assigned

Labels

front-end front-end-deps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalKarol @ad-m @fervero