Skip to content

Too many claims fix #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankomix wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Too many claims fix #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,8 @@ server/common/build.info.js
.env
.idea
/.project
/nbproject/private/
/nbproject/private/
.DS_Store
nbproject/*
server/.DS_Store
server/api/.DS_Store
17 changes: 17 additions & 0 deletions server/api/services/wikidata.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,17 @@ class WikidataService {
return res;
}

filterClaims(allClaims, claims) {
const newClaims = {};
for (let item of claims) {
if (Object.keys(allClaims).indexOf(item) !== -1 && Object.keys(allClaims).indexOf('P625') !== -1) {
newClaims[item] = allClaims[item];
} else if (Object.keys(allClaims).indexOf('P625') !== -1) {
newClaims['P625'] = allClaims['P625'];
}
}
return newClaims;
}

byIds(qids,locationName) {
// fetch fountains by their QIDs
Expand Down Expand Up @@ -115,7 +126,13 @@ class WikidataService {
}
// concatenate the fountains from each chunk into "dataAll"
dataAll = dataAll.concat(data);

});

dataAll.forEach((element, i) => {
element.claims = this.filterClaims(element.claims, ['P856', 'P973', 'P854', 'P2699', 'P625'])
})

if (1 == chkCnt) {
let dataAllSize = -1;
if (null != dataAll) {
Expand Down