Skip to content

Conversation

@ordinaryparksee
Copy link

  • Added support for internal domain names (e.g., Docker/Kubernetes service names)
  • Enables recognition of service discovery-style URLs in addition to public domains, localhost, and IP addresses
  • Maintains existing support for optional ports and paths

- Added support for internal domain names (e.g., Docker/Kubernetes service names)
- Enables recognition of service discovery-style URLs in addition to public domains, localhost, and IP addresses
- Maintains existing support for optional ports and paths
@ordinaryparksee
Copy link
Author

Refer this issue : #4

@amirasaran
Copy link
Contributor

Hey @ordinaryparksee,
Thanks for your contribution. But I preferred to use something like the following code instead of a regex check. Additionally, with the regex, we also encounter another problem that was previously reported by users.

def validate_url(self, url) -> bool:
    try:
        result = urlparse(url)
        return all([result.scheme in ("http", "https"), result.netloc])
    except ValueError:
        return False

Please update your branch, then I can merge and make a new release for the requested changes.

@amirasaran amirasaran self-requested a review September 24, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants