Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 34.65% 39.18% +4.52%
==========================================
Files 1088 1093 +5
Lines 63091 63937 +846
==========================================
+ Hits 21866 25052 +3186
+ Misses 39574 37077 -2497
- Partials 1651 1808 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ata structures, updating coverage analysis logic, and improving output formatting
…ata structures, updating coverage analysis logic, and improving output formatting
…ata structures, updating coverage analysis logic, and improving output formatting
…ata structures, updating coverage analysis logic, and improving output formatting
…pdate coverage statistics
…ing test coverage
…te coverage statistics
…verage improvements
Feature/test coverage
There was a problem hiding this comment.
Pull Request Overview
This PR delivers the Release 142 changes, mainly expanding test coverage across Dropbox-related use cases and filesystem modules, adding documentation and recipes for test coverage commands, and tweaking CI and core logic.
- Add extensive unit tests for
uc_insight,uc_file_merge,dbx_fs_copier_batch,dbx_fs, and core logging - Introduce docs and recipe registrations for the
dev test coveragecommands - Fix the
Applyrecursion inCaptureAggregatorOptsand includefeature/*branches in CI triggers
Reviewed Changes
Copilot reviewed 109 out of 109 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| domain/dropbox/usecase/uc_insight/data_errors_test.go | New tests for ApiErrorFromError and ApiErrorReport |
| domain/dropbox/usecase/uc_file_merge/options_test.go | Tests for MergeOpts builder functions |
| domain/dropbox/usecase/uc_file_merge/msg_test.go | Tests for MMerge message initialization |
| domain/dropbox/filesystem/dbx_fs_copier_batch/data_type_test.go | JSON marshal/unmarshal and constant checks for data types |
| domain/dropbox/filesystem/dbx_fs_copier_batch/coiper_test.go | Tests for NewLocalToDropboxBatch and copier struct init |
| domain/dropbox/filesystem/dbx_fs/filesystem_test.go | Tests for NewFileSystem, complexity logic, and constants |
| domain/dropbox/filesystem/dbx_fs/filesystem_cached_test.go | Tests for cached filesystem message initialization |
| domain/dropbox/filesystem/dbx_fs/error_test.go | Tests for dbxError and cacheError behaviors |
| domain/core/dc_log/capture.go | Fix recursion in CaptureAggregatorOpts.Apply |
| docs/commands/dev-test-coverage-summary.md | Add dev test coverage summary command docs |
| docs/commands/dev-test-coverage-pkg.md | Add dev test coverage pkg command docs |
| docs/commands/dev-test-coverage-list.md | Add dev test coverage list command docs |
| catalogue/recipe.go | Register new recipedevtestcoverage recipes |
| .github/workflows/test.yml | Expand CI to trigger on feature/* branches |
| docs/_posts/2025-06-16-release-142.md | New post for Release 142 |
| docs/_posts/2025-06-15-release-141.md | Update release 141 metadata |
Comments suppressed due to low confidence (5)
domain/dropbox/usecase/uc_file_merge/options_test.go:27
- The function name ClearEmptyFolder and the field CleanEmptyFolder use different verbs. Consider renaming for consistency (e.g., CleanEmptyFolder both as function and field).
if !opts.CleanEmptyFolder {
domain/dropbox/filesystem/dbx_fs_copier_batch/coiper_test.go:1
- The filename
coiper_test.goappears to be a typo. Rename it tocopier_test.goto match the package name.
package dbx_fs_copier_batch
docs/commands/dev-test-coverage-summary.md:100
- Remove the extra period after "detail" so it reads "...for more detail. Default: false".
**-verbose**: Show current operations for more detail.. Default: false
docs/commands/dev-test-coverage-pkg.md:100
- Remove the extra period after "detail" so it reads "...for more detail. Default: false".
**-verbose**: Show current operations for more detail.. Default: false
docs/commands/dev-test-coverage-list.md:106
- Remove the extra period after "detail" so it reads "...for more detail. Default: false".
**-verbose**: Show current operations for more detail.. Default: false
|
|
||
| for i, constant := range constants { | ||
| if constant == "" { | ||
| t.Errorf("Constant %d should not be empty", i) |
There was a problem hiding this comment.
[nitpick] Include the constant's value or name in the error message for easier debugging, e.g., t.Errorf("Constant %q should not be empty", constant).
Suggested change
| t.Errorf("Constant %d should not be empty", i) | |
| t.Errorf("Constant at index %d (%q) should not be empty", i, constant) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.