This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Open
Conversation
069ed5c to
960f208
Compare
Member
|
Here's code conventions for this project. |
Member
|
@fwextensions Mind if I branch off this and break it up into multiple PRs? |
Use proper file URLs when dynamically importing JS files, instead of relying on absolute macOS file paths looking like parts of URLs. Generate paths only in config.js.
70a89f7 to
efd34aa
Compare
Remove the double `format` in identity-source.js. Log detailed info for sources with missing fields. Add Fuse.js package to search for possible matches of missing fields. Fix "numberic" and other typos. Check for JSON appearing in .csv files. Add support for custom ogr2ogr command in .env file, to handle Windows usage. Update README.md with Windows install info.
efd34aa to
35d6417
Compare
Member
Author
|
Making ogr work on Windows is just a few lines of code, but feel free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lintnpm script.ogr2ogrcommand in .env file, to handle Windows usage.formatin identity-source.js.Running
npm run downloadand thennpm run lintwill check the crosswalk fields specified in each source against its downloaded .csv file. Fields that aren't found in the header row of the file are listed, along with any column names that are similar. Example output for Escondido:#20 and #21 should be merged before this PR.