refactor: Create fresh baseclient for secure

mediumTaj · mediumTaj · commit fc07483328e9 · 2018-11-08T16:05:52.000-06:00
diff --git a/src/IBM.WatsonDeveloperCloud/Http/WatsonHttpClient.cs b/src/IBM.WatsonDeveloperCloud/Http/WatsonHttpClient.cs
@@ -83,7 +83,7 @@ public IClient WithAuthentication(string userName, string password)
 
         public IClient WithAuthentication(string apikey)
         {
-            if(!string.IsNullOrEmpty(apikey))
+            if (!string.IsNullOrEmpty(apikey))
             {
                 this.BaseClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", apikey);
             }
@@ -174,9 +174,7 @@ public void SendAsInsecure(bool insecure)
             }
             else
             {
-                var httpClientHandler = new HttpClientHandler();
-                httpClientHandler.ServerCertificateCustomValidationCallback = null;
-                this.BaseClient = new HttpClient(httpClientHandler);
+                this.BaseClient = new HttpClient();
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public IClient WithAuthentication(string userName, string password)`
`83`	`83`
`84`	`84`	`public IClient WithAuthentication(string apikey)`
`85`	`85`	`{`
`86`		`- if(!string.IsNullOrEmpty(apikey))`
	`86`	`+ if (!string.IsNullOrEmpty(apikey))`
`87`	`87`	`{`
`88`	`88`	`this.BaseClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", apikey);`
`89`	`89`	`}`
`@@ -174,9 +174,7 @@ public void SendAsInsecure(bool insecure)`
`174`	`174`	`}`
`175`	`175`	`else`
`176`	`176`	`{`
`177`		`- var httpClientHandler = new HttpClientHandler();`
`178`		`- httpClientHandler.ServerCertificateCustomValidationCallback = null;`
`179`		`- this.BaseClient = new HttpClient(httpClientHandler);`
	`177`	`+ this.BaseClient = new HttpClient();`
`180`	`178`	`}`
`181`	`179`	`}`
`182`	`180`	`}`