Skip to content

Fix on_close propogation + bump websocket-client #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix on_close propogation + bump websocket-client #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dbbec3
Update requirements.txt
wwwehr Apr 17, 2022
6f8da90
Accept expected on_close signature
wwwehr Apr 17, 2022
03e5b18
Merge pull request #1 from wehr-enterprises/wwwehr-patch-1
wwwehr Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ibm_watson/websocket/synthesize_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def on_error(self, ws, error):
"""
self.callback.on_error(error)

def on_close(self, ws, **kwargs):
def on_close(self, ws, *args, **kwargs):
"""
Callback executed when websocket connection is closed

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests>=2.0,<3.0
python_dateutil>=2.5.3
websocket-client==1.1.0
websocket-client==1.3.0
ibm_cloud_sdk_core>=3.3.6, == 3.*