Skip to content

feat(multi_window): send iced::window::Event::Closed.#136

Merged
Decodetalkers merged 1 commit intowaycrate:masterfrom
fortime:feat/window-closed-event
Mar 7, 2025
Merged

feat(multi_window): send iced::window::Event::Closed.#136
Decodetalkers merged 1 commit intowaycrate:masterfrom
fortime:feat/window-closed-event

Conversation

@fortime
Copy link
Copy Markdown
Contributor

@fortime fortime commented Mar 7, 2025

Send iced::window::Event::Closed after a window is removed. This will be more consistent with the behavior of iced_winit. It also make handling after-closed tasks more easily compared to remove_id.

Signed-off-by: fortime <palfortime@gmail.com>
@Decodetalkers Decodetalkers merged commit 5a47b5f into waycrate:master Mar 7, 2025
3 checks passed
@Decodetalkers
Copy link
Copy Markdown
Collaborator

thank you very much

@Decodetalkers
Copy link
Copy Markdown
Collaborator

I found that you are writing a virtualkeyboard program, so should I publish a new version for you? That is really a good project

@fortime
Copy link
Copy Markdown
Contributor Author

fortime commented Mar 7, 2025

Thank you. But currently there is no need for a new version. My project is still WIP. It won't be released in the near future.
BTW, there are two PRs on the way😆. And I am debugging a panic during closing the first window of multi_window.

@fortime fortime deleted the feat/window-closed-event branch March 11, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants