Skip to content

feat(namespace): allow setting namespace when a new window is opened. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Decodetalkers merged 2 commits into from
May 14, 2025
Merged

feat(namespace): allow setting namespace when a new window is opened. #142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b4a228
feat(layershell): allow setting namespace when a new window is opened.
fortime Mar 7, 2025
0819e9f
fix: remove redundancy clone.
fortime May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion layershellev/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ pub enum LayerEvent<'a, T, Message> {
}

/// layershell settings to create a new layershell surface
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct NewLayerShellSettings {
/// the size of the layershell, optional.
pub size: Option<(u32, u32)>,
Expand All @@ -83,6 +83,7 @@ pub struct NewLayerShellSettings {
/// wl_output.
pub use_last_output: bool,
pub events_transparent: bool,
pub namespace: Option<String>,
}

/// be used to create a new popup
Expand Down Expand Up @@ -119,6 +120,7 @@ impl Default for NewLayerShellSettings {
keyboard_interactivity: KeyboardInteractivity::OnDemand,
use_last_output: false,
events_transparent: false,
namespace: None,
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion layershellev/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,6 +2833,7 @@ impl<T: 'static> WindowState<T> {
keyboard_interactivity,
use_last_output,
events_transparent,
namespace,
},
id,
info,
Expand Down Expand Up @@ -2864,7 +2865,7 @@ impl<T: 'static> WindowState<T> {
&wl_surface,
output,
layer,
window_state.namespace.clone(),
namespace.clone().unwrap_or_else(|| window_state.namespace.clone()),
Copy link
Copy Markdown
Collaborator

@Decodetalkers Decodetalkers May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the first clone is not needed I think

Copy link
Copy Markdown
Contributor Author

@fortime fortime May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. It's weird that I remember it is a reference before. And clippy doesn't find it out.

&qh,
(),
);
Expand Down