Skip to content

Revert "Merge pull request #31 from wayfair-incubator/fix-no-partial-…#32

Merged
Maheswari6 merged 2 commits intomainfrom
mk228f_revert-fix-no-partial-shareable-types
Oct 13, 2025
Merged

Revert "Merge pull request #31 from wayfair-incubator/fix-no-partial-…#32
Maheswari6 merged 2 commits intomainfrom
mk228f_revert-fix-no-partial-shareable-types

Conversation

@Maheswari6
Copy link
Collaborator

@Maheswari6 Maheswari6 commented Oct 13, 2025

…shareable-value-type"

This reverts commit 5d5d3da, reversing changes made to 8e6e41f.

Description

Adding all the shareable value types resulted in an invalid graphql schema because of missing return type definitions.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the
    contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

…shareable-value-type"

This reverts commit 5d5d3da, reversing
changes made to 8e6e41f.
@Maheswari6 Maheswari6 marked this pull request as ready for review October 13, 2025 18:18
@Maheswari6 Maheswari6 requested a review from a team as a code owner October 13, 2025 18:18
Copy link
Collaborator

@gwardwell gwardwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to do an npm package rollback, but the next version with changes will have to be 2.2.4 and you may want to un-publish 2.2.3.

Alternatively you could release the rollback as 2.2.4.

I'd look for conventions on how to handle it.

@Maheswari6 Maheswari6 merged commit 074bbad into main Oct 13, 2025
5 checks passed
@Maheswari6 Maheswari6 deleted the mk228f_revert-fix-no-partial-shareable-types branch October 13, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants