bump to stretch, ensure ssl-dev is installed#2131
Draft
clundquist-stripe wants to merge 1 commit intowazuh:masterfrom
Draft
bump to stretch, ensure ssl-dev is installed#2131clundquist-stripe wants to merge 1 commit intowazuh:masterfrom
clundquist-stripe wants to merge 1 commit intowazuh:masterfrom
Conversation
4c5ee2f to
bf27bd2
Compare
rauldpm
suggested changes
Mar 28, 2023
Member
rauldpm
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution.
- Regarding the changes referring to the AMD64 Dockerfile, they seem correct to me since for consistency with the other Dockerfiles the package should be built in the same system (Debian Stretch) and therefore, the dependency changes should be consistent.
- Regarding specifying the platform flag, I ask you for consistency either all Dockerfiles use
--platformor use the formatarchitecture/debian:stretch - Regarding the
libssl1.0-devpackage we must validate if it is really necessary, according to the documentation, thelibssl-devpackage should be installed
In any case, it is necessary to share a full build output of an ARM64 and AMD64 package build with the new Dockerfiles in order to be accepted.
Regarding the node package, it is used in the construction of the Wazuh API, which has already been deprecated, I will ask the team why this package is still present and we will create an issue if it should be removed.
| @@ -1,18 +1,19 @@ | |||
| FROM debian:7 | |||
| FROM --platform=linux/amd64 debian:stretch | |||
Member
There was a problem hiding this comment.
For consistency, please use the flag --platform or use the format architecture/debian:stretch in all Debian Dockerfiles
| autoconf libtool libaudit-dev selinux-basics \ | ||
| libdb5.3 libdb5.3 libssl1.0.2 libssl1.0-dev gawk libsigsegv2 | ||
|
|
||
| # Add Debian's source repository and, Install NodeJS 12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wheezy GPG keys have expired, and building for AMD64 no longer works.
This bumps the amd64 docker image to match the arm64 (ARM) one for the most part.
I'm unclear why
nodeis needed for the arm64 build. Building amd64 worked without it.This also adds the
--platformflag to slightly better support Apple M1 Rossetta and cross compiling.Logs example
Current
master:note:
W: GPG error: http://archive.debian.org wheezy Release: The following signatures were invalid: KEYEXPIRED 1587841717 KEYEXPIRED 1668891673 KEYEXPIRED 1557241909Tests
%filessection is correctly updated if necessary%filessection is correctly updated if necessary