Open
Conversation
… 14-upstart-systemd-check
DFolchA
force-pushed
the
14-upstart-systemd-check
branch
from
7dbf469 to
84e8454
Compare
alberpilot
reviewed
Jan 24, 2020
| # Service | ||
| if [ -f /etc/init.d/wazuh-agent ]; then | ||
| if [ -d /run/systemd/system ]; then | ||
| if [ ! -z "$(file /sbin/init |grep "systemd")" ]; then |
Contributor
There was a problem hiding this comment.
Question: what about to use:
if [ ! -z "$(file /sbin/init |grep 'systemd')" ]; then
instead?
alberpilot
reviewed
Jan 24, 2020
|
|
||
| if [ -d /run/systemd/system ] ; then | ||
|
|
||
| if [ ! -z "$(file /sbin/init |grep "systemd")" ]; then |
Contributor
There was a problem hiding this comment.
alberpilot
reviewed
Jan 24, 2020
| # Service | ||
| if [ -x /etc/init.d/wazuh-manager ]; then | ||
| if [ -d /run/systemd/system ]; then | ||
| if [ ! -z "$(file /sbin/init |grep "systemd")" ]; then |
Contributor
There was a problem hiding this comment.
alberpilot
reviewed
Jan 24, 2020
|
|
||
|
|
||
| if [ -d /run/systemd/system ] ; then | ||
| if [ ! -z "$(file /sbin/init |grep "systemd")" ]; then |
Contributor
There was a problem hiding this comment.
alberpilot
suggested changes
Jan 24, 2020
Contributor
alberpilot
left a comment
alberpilot
left a comment
There was a problem hiding this comment.
Please review the comments. On the other hand, please update the currents specs and pull your branch.
… 14-upstart-systemd-check
Contributor
Author
|
Hello team, I implemented the requested changes and tested the package generated from the new specs in ubuntu 14 LTS with the I have also tested it on a default Ubuntu 14 LTS, Ubuntu 16 LTS, and Ubuntu 18 LTS Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team,
This PR closes #14, I have changed how the post-installation script checked if systemd and its functions were available, from checking whether the /run/systemd/system directory existed to verifying if systemd is being used to initiate the system.
I have generated packages and tested them in:
Regards,
Daniel Folch