Support for binary ids and rails custom fields#15
Open
pnegri wants to merge 1 commit intowbotelhos:mainfrom
Open
Support for binary ids and rails custom fields#15pnegri wants to merge 1 commit intowbotelhos:mainfrom
pnegri wants to merge 1 commit intowbotelhos:mainfrom
Conversation
pnegri
commented
Apr 10, 2023
| #{scope_where_query(resource)} | ||
| ).squish | ||
|
|
||
| values = [sql, resource.class.base_class.name, resource.id] |
Author
There was a problem hiding this comment.
Using .id will bypass rails field serialization
Owner
|
Hey, @pnegri , I didn't receive notification about your PR, I'm sorry. Do you think is it possible create a simple test to represent this case? |
Owner
|
Hi, @pnegri I didn't merge it yet because we need some kind of tests. As soon as I have time I'll study about this Rails feature that I never used so I can't understand the problem/solution for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem when you try to use columns that aren't integer or string, also, when you use Rails 6+ Custom Field Types. When you call active model sanitizers, active model converts array of parameters by calling serializers for each model field/column, if you call "id" directly on these models, it will bypass the rails serializers and cast and will try to use the field.to_s as column value, resulting into a wrong value on the reference table.