Skip to content

Allow 'atom_modify map yes|array|hash' for lammps pair style#58

Merged
wcwitt merged 1 commit intodevelopfrom
lammps_atom_modify_map
Dec 8, 2025
Merged

Allow 'atom_modify map yes|array|hash' for lammps pair style#58
wcwitt merged 1 commit intodevelopfrom
lammps_atom_modify_map

Conversation

@bernstei
Copy link
Copy Markdown
Collaborator

@bernstei bernstei commented Dec 5, 2025

Revive fix from #48 which got lost during packaging PR merge

@bernstei
Copy link
Copy Markdown
Collaborator Author

bernstei commented Dec 8, 2025

@wcwitt any idea why these tests are failing after the innocuous change?

@wcwitt
Copy link
Copy Markdown
Owner

wcwitt commented Dec 8, 2025

Thanks for this! I think it's something unrelated to your change - I added a float32 option to lammps in develop and I believe those test tolerances need some attention. I saw something similar late last week.

I will merge into develop now and try to fix the problem there.

@wcwitt wcwitt merged commit aef0e8a into develop Dec 8, 2025
3 of 4 checks passed
@wcwitt wcwitt deleted the lammps_atom_modify_map branch December 8, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants