Open
Conversation
Owner
|
Thanks! Do you think this is ready to merge? |
Author
|
I think it is. I am just waiting for sphericart folks to accept my merge
request. You can try my sphericart fork, also make comments in my request:
thumbs up, endorsement, etc.
Other than that this part is done.
…On Tue, Mar 10, 2026, 8:19 AM wcwitt ***@***.***> wrote:
*wcwitt* left a comment (wcwitt/symmetrix#72)
<#72 (comment)>
Thanks! Do you think this is ready to merge?
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZWCU7WQLJZG3NSUQLYUQD4QAI55AVCNFSM6AAAAACV5FAKGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMZRGMZTANJWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
@wcwitt See this comment regarding speed up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this with my fork https://github.com/alvarovm/sphericart.
Tested in Intel PVC with Intel oneapi 2025.3