fran hw, minimal styling#10
Open
CescoIV wants to merge 1 commit intowdi-atx-12:masterfrom
CescoIV:fran_hw
Open
fran hw, minimal styling#10CescoIV wants to merge 1 commit intowdi-atx-12:masterfrom CescoIV:fran_hw
CescoIV wants to merge 1 commit intowdi-atx-12:masterfrom
CescoIV:fran_hw
Conversation
BritneyJo
reviewed
Sep 27, 2017
BritneyJo
left a comment
BritneyJo
left a comment
There was a problem hiding this comment.
Next time you can google for a CDN for the flag library instead of downloading and using node to install. That will eliminate having 500+ files you have to add to the repo: https://cdnjs.com/libraries/flag-icon-css
| function setIcon(data){ | ||
| console.log(data.weather[0].icon); | ||
| var icon_code = data.weather[0].icon; | ||
| var icon_src = '<img src="http://openweathermap.org/img/w/' +icon_code+'.png">'; |
There was a problem hiding this comment.
With all of the quotes in this string concatenation, i'd recommend using ES6 syntax.
| $('.description-label').text(label); | ||
| $('.description').text(desc); | ||
| } | ||
| function clearWeather(){ |
There was a problem hiding this comment.
You may want to clear the text input here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.