Open
Conversation
BritneyJo
reviewed
Sep 27, 2017
BritneyJo
left a comment
BritneyJo
left a comment
There was a problem hiding this comment.
Next time you can google for a CDN for the flag library instead of downloading and using node to install. That will eliminate having 500+ files you have to add to the repo: https://cdnjs.com/libraries/flag-icon-css
| @@ -4,48 +4,57 @@ | |||
| <meta charset="utf-8"> | |||
| <title>Mini Weather App</title> | |||
| <link rel="stylesheet" href="css/style.css"> | |||
There was a problem hiding this comment.
Make sure your custom CSS file is loaded after any libraries you may be using (i.e. boostratp, googlefonts, flags)
| <div class="row form-row"> | ||
| <div class="col-md-4 col-md-offset-4"> | ||
| <div class="header"> | ||
| <div class="weat"> |
There was a problem hiding this comment.
Confusing class name... While it definitely works, it's not super clear to another dev.
| $(function(){ | ||
| console.log("Listo!"); | ||
| requestWeatherData(); | ||
| $("form").submit(function(event){ |
| }) | ||
| } | ||
|
|
||
| function onSuccess(data){ |
There was a problem hiding this comment.
You'll want to make sure to clear out the text input after a successful data display too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.