Skip to content

James Tang weather app #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TangJames wants to merge 1 commit into
base: master
Choose a base branch
from
Open

James Tang weather app #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
<head>
<meta charset="utf-8">
<title>Mini Weather App</title>
<link rel="stylesheet" href="css/style.css">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">
<link rel="stylesheet" href="css/style.css">
<script src="js/jquery.min.js"></script>
<script src="js/main.js"></script>
</head>
<body>
<main class="weather-app container">
Expand All @@ -13,8 +15,10 @@
<div class="col-md-4 col-md-offset-4">
<h1 class="title">Weather App</h1>
<form class="getWeatherData">
<input type="text" class="weather-city" placeholder="Enter a city.."/>
<input type="text" class="weather-city" name="q" placeholder="Enter a city.."/>
<input type="submit" value="Get Weather">
<input type="hidden" name="appid" value="3501f282f2cd6fc99583263cfdc07353">
<input type="hidden" name="units" value="imperial">
<p class="city-error" style="display:none;">Whoops! Looks like that city doesn't exist, try another one.</p>
</form>
</div>
Expand All @@ -23,7 +27,7 @@ <h1 class="title">Weather App</h1>
<div class="row">
<div class="col-md-4 col-md-offset-4 results">

<h2 class="results-city"></h2>
<div class="icon-container"></div>


<div class="temperature-container">
Expand All @@ -45,7 +49,6 @@ <h2 class="results-city"></h2>
</div>

</main>
<script src="js/jquery.min.js"></script>
<script src="js/main.js"></script>

</body>
</html>
42 changes: 41 additions & 1 deletion js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,41 @@
/* Javascript goes here! */
console.log("helloworld!");
$(document).ready( function(){
console.log('I am ready for this stuff');
// eventually this should be triggered by search button
$("form").submit(function(e) {
e.preventDefault();
Copy link
Copy Markdown

@BritneyJo BritneyJo Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch your indents!

requestWeatherData();
});
});

function requestWeatherData() {
// this should request live weather data from API
// eventually based on what the user searches
console.log('Requesting Data');

$.ajax({
method: 'GET',
url: 'http://api.openweathermap.org/data/2.5/weather',
data: $("form").serialize(),
dataType: 'json',
success: onSuccess,
error: onError,
});
}

function onSuccess(data) {
// TODO: code me
var imgSource = `http://openweathermap.org/img/w/${data.weather[0].icon}.png`;

$('.temperature').html(data.main.temp);
$('.description').html(data.weather[0].description);
$('.icon-container').html(`<img src=${imgSource}>`);
console.log('Request successful');
console.log(data);
}

function onError() {
// TODO: code me
$('.city-error').css('display', 'block');
console.log('Oops its broken');
};