Dazaev did his weather app in metric units cause hes mexican#9
Open
dazaevvc wants to merge 1 commit intowdi-atx-12:masterfrom
Open
Dazaev did his weather app in metric units cause hes mexican#9dazaevvc wants to merge 1 commit intowdi-atx-12:masterfrom
dazaevvc wants to merge 1 commit intowdi-atx-12:masterfrom
Conversation
BritneyJo
reviewed
Sep 27, 2017
BritneyJo
left a comment
BritneyJo
left a comment
There was a problem hiding this comment.
Next time you can google for a CDN for the flag library instead of downloading and using node to install. That will eliminate having 500+ files you have to add to the repo: https://cdnjs.com/libraries/flag-icon-css
| @@ -5,16 +5,17 @@ | |||
| <title>Mini Weather App</title> | |||
| <link rel="stylesheet" href="css/style.css"> | |||
There was a problem hiding this comment.
Make sure your custom CSS file is loaded after any libraries you're using (i.e. bootstrap and flags).
| $(document).ready(function(){ | ||
| console.log("ready!"); | ||
| //this is what has to be triggered when they look for weather and click submit | ||
| $("#fetchWeather").click(function(event){ |
There was a problem hiding this comment.
This doesn't look like it's doing anything?
| }) | ||
|
|
||
| function currentTemperature(){ | ||
|
|
There was a problem hiding this comment.
I thought you were going to convert kelvin to celsius since you're mexican!!
| $("h3.results-country").append('<img class="flagger" src="flag-icon-css-master/flags/1x1/'+data.sys.country+'.svg">'); | ||
| $(".temperature-label").append(data.main.temp); | ||
| $(".humidity-label").append(data.main.humidity); | ||
| $("span.description-label").append(data.weather[0].main); |
There was a problem hiding this comment.
Last piece will then be to clear out the main input once the data has been retrieved and displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.