Fixes issues related to using consecutive slices in MTLRS and SKMTEA#8
Open
TimPaquaij wants to merge 5 commits intowdika:mainfrom
Open
Fixes issues related to using consecutive slices in MTLRS and SKMTEA#8TimPaquaij wants to merge 5 commits intowdika:mainfrom
TimPaquaij wants to merge 5 commits intowdika:mainfrom
Conversation
**.DS_Store Changed loaders to get multiple echoes for skmtea Added num_echoes in base include consecutative slices and double echo added consecutative and finalised echo Update on consecutatiive slices and echoes still error in target reconstruction Update Train and val + plotting works Validation and Training passed with SSIM fixed test script and hx can be an empty list or none Update Spacing Update test_step update to prevent diffeculties with merging Update base.py and mtlrs.py remove print and update log_indices to test plotting Update SSIM with batch size Update base.py update style base.py update requirements.txt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| prediction = prediction[-1][-1][-1] | ||
| loss = compute_reconstruction_loss(target, prediction, sensitivity_maps) | ||
| if self.consecutive_slices > 1: | ||
| loss = compute_reconstruction_loss( |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
Owner
There was a problem hiding this comment.
@wdika check this, atm line 323 will overwrite 318 loss computation
atommic/collections/reconstruction/data/mri_reconstruction_loader.py
Outdated
Show resolved
Hide resolved
wdika
reviewed
Dec 8, 2025
Signed-off-by: Dimitris Karkalousos <d.karkalousos@amsterdamumc.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes implementation of consecutive slices in multi-task collection. Additionally, it adds the possibility to run multiple echoes in one inference.
Collection: Multi-task
Changelog
Usage
SKMTEA Example
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information