-
Notifications
You must be signed in to change notification settings - Fork 91
enhance: image in quick search result #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sapayth
wants to merge
15
commits into
weDevsOfficial:develop
Choose a base branch
from
sapayth:enhance/image_in_quick_search_result
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
426a5b2
initial setup
sapayth b800055
quick search input field stylings
sapayth b033727
initial frontend modal rendering
sapayth 5e063a9
initial search response
sapayth e43aaf4
frontend search better UX
sapayth 126e085
frontend UX improvement
sapayth a8a7dd1
search modal styling
sapayth eb75ac2
Modal Docs Source implementation
sapayth 53fcb02
section, article checking for predefined docs
sapayth f174e23
added show icon option
sapayth 6419b10
cs fixes
sapayth a6834a7
enhance: image in quick search result
sapayth c8db3e8
Merge remote-tracking branch 'upstream/develop' into enhance/image_in…
sapayth cfc3df5
fix: conflict with existing quick search
sapayth 019e279
Merge remote-tracking branch 'upstream/develop' into enhance/image_in…
sapayth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 18 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| <?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n', 'wp-primitives'), 'version' => '5c13835270f8b2070a23'); | ||
| <?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n', 'wp-primitives'), 'version' => '748e985bc8616f514a4a'); |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/block.json", | ||
| "apiVersion": 3, | ||
| "name": "wedocs/quick-search", | ||
| "version": "1.0.0", | ||
| "title": "weDocs - Quick Search", | ||
| "icon": "search", | ||
| "category": "widgets", | ||
| "description": "Add a quick search block that opens a modal with documentation search", | ||
| "supports": { | ||
| "html": false | ||
| }, | ||
| "render": "file:./render.php", | ||
| "attributes": { | ||
| "searchBoxPlaceholder": { | ||
| "type": "string", | ||
| "default": "Quick search..." | ||
| }, | ||
| "modalPlaceholder": { | ||
| "type": "string", | ||
| "default": "Search documentation" | ||
| }, | ||
| "modalDocsSource": { | ||
| "type": "string", | ||
| "default": "helpful" | ||
| }, | ||
| "sectionIds": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "articleIds": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "helpfulDocsCount": { | ||
| "type": "number", | ||
| "default": 10 | ||
| }, | ||
|
Comment on lines
+35
to
+38
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Schema missing attributes used elsewhere (breaks featured/icon/none and styling). Add:
"helpfulDocsCount": {
"type": "number",
"default": 10
},
+ "resultImageType": {
+ "type": "string",
+ "default": "icon"
+ },
@@
"modalStyles": {
"type": "object",
"default": {
"placeholderColor": "#9CA3AF",
"searchIconColor": "#6B7280",
"backgroundColor": "#FFFFFF",
"fieldTextColor": "#111827",
"listItemIconColor": "#3B82F6",
"listItemTextColor": "#111827",
"docLabelColor": "#3B82F6",
"sectionLabelColor": "#3B82F6",
+ "articleLabelColor": "#8B5CF6",
"listItemPadding": {
"top": "12px",
"right": "16px",
"bottom": "12px",
"left": "16px"
},
"listItemMargin": {
"top": "0px",
"right": "0px",
"bottom": "0px",
"left": "0px"
},
"listItemBorderColor": "#E5E7EB",
"listItemBorderWidth": "1px",
- "listItemBorderRadius": "4px"
+ "listItemBorderRadius": "4px",
+ "listItemBackgroundColor": "#F9FAFB",
+ "listItemIconBackgroundColor": "transparent"
}
}Also applies to: 67-95 🤖 Prompt for AI Agents |
||
| "searchBoxStyles": { | ||
| "type": "object", | ||
| "default": { | ||
| "placeholderColor": "#9CA3AF", | ||
| "iconColor": "#6B7280", | ||
| "commandKeyColor": "#6B7280", | ||
| "backgroundColor": "#FFFFFF", | ||
| "borderColor": "#D1D5DB", | ||
| "borderWidth": "1px", | ||
| "borderRadius": "8px", | ||
| "padding": { | ||
| "top": "12px", | ||
| "right": "16px", | ||
| "bottom": "12px", | ||
| "left": "16px" | ||
| }, | ||
| "margin": { | ||
| "top": "0px", | ||
| "right": "0px", | ||
| "bottom": "0px", | ||
| "left": "0px" | ||
| }, | ||
| "fontSize": "16px", | ||
| "fontWeight": "400", | ||
| "letterSpacing": "0px", | ||
| "lineHeight": "1.5" | ||
| } | ||
| }, | ||
| "modalStyles": { | ||
| "type": "object", | ||
| "default": { | ||
| "placeholderColor": "#9CA3AF", | ||
| "searchIconColor": "#6B7280", | ||
| "backgroundColor": "#FFFFFF", | ||
| "fieldTextColor": "#111827", | ||
| "listItemIconColor": "#3B82F6", | ||
| "listItemTextColor": "#111827", | ||
| "docLabelColor": "#3B82F6", | ||
| "sectionLabelColor": "#3B82F6", | ||
| "listItemPadding": { | ||
| "top": "12px", | ||
| "right": "16px", | ||
| "bottom": "12px", | ||
| "left": "16px" | ||
| }, | ||
| "listItemMargin": { | ||
| "top": "0px", | ||
| "right": "0px", | ||
| "bottom": "0px", | ||
| "left": "0px" | ||
| }, | ||
| "listItemBorderColor": "#E5E7EB", | ||
| "listItemBorderWidth": "1px", | ||
| "listItemBorderRadius": "4px" | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Node baseline to a still-supported LTS
.nvmrcnow pins Node 18, which reached end-of-life on April 30 2025 and no longer receives security fixes. Please move to an actively supported LTS (e.g., Node 20) before merging so local builds don’t rely on an unpatched runtime.Apply this diff to bump the pinned version:
📝 Committable suggestion
🤖 Prompt for AI Agents