-
Notifications
You must be signed in to change notification settings - Fork 15
Fix check for default branch on received webhook, allowing for a custom one #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
============================================
+ Coverage 72.35% 72.72% +0.37%
- Complexity 410 414 +4
============================================
Files 28 28
Lines 1248 1265 +17
============================================
+ Hits 903 920 +17
Misses 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @ocean90 👋 |
|
Looks like some unit tests need updating. After that I need to defer to @ocean90 for review. |
…use it is already checked in the permission callback
|
Hi there 👋 |
Head branch was pushed to by a user without write access
|
Oooops sorry, I didn't notice the code sniffer error! |
Head branch was pushed to by a user without write access
Description
Add the filter to customize the branch to elaborate when a webhook is received. Since most of the logic is common between the handlers, it has been extracted to the Base class.
Add the repository name to the existing filter to allow resolving the project inside the filter.
How has this been tested?
I tested this feature locally with some limitations. I tested sending a webhook, and I can see the request is going through without errors.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Fixes #280
Checklist: